created new snapshot method - fixes #537 #572
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
irevoire
previously approved these changes
Apr 17, 2024
Contributor
irevoire
left a comment
irevoire
left a comment
There was a problem hiding this comment.
Perfect thanks!
bors merge
meili-bors bot
added a commit
that referenced
this pull request
Apr 17, 2024
572: created new snapshot method - fixes #537 r=irevoire a=NoodleSamaChan # Pull Request ## Related issue Fixes #537 ## What does this PR do? - creates new snapshot method ## PR checklist Please check if your PR fulfills the following requirements: - [x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)? - [x] Have you read the contributing guidelines? - [x] Have you made sure that the title is accurate and descriptive of the changes? Thank you so much for contributing to Meilisearch! Co-authored-by: NoodleSamaChan <[email protected]>
Contributor
|
Build failed: |
Member
|
@NoodleSamaChan thank you for your PR |
irevoire
approved these changes
Apr 17, 2024
Contributor
irevoire
left a comment
irevoire
left a comment
There was a problem hiding this comment.
tanks @curquiza & @NoodleSamaChan
bors merge
Contributor
Author
|
apologies for the bother, I redid the formatting, hope it fixes the issue! |
Contributor
|
Build succeeded:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Related issue
Fixes #537
What does this PR do?
PR checklist
Please check if your PR fulfills the following requirements:
Thank you so much for contributing to Meilisearch!